+1 binding Checked sigs and sums: Matched LICENSE and NOTICE: Looks fine DISCLAIMER: In place Built from src: Passed with the guide from this link https://github.com/apache/incubator-brpc/blob/master/docs/cn/getting_started.md Run demo: I ran the demo listed in the above link, looks fine
I suggest you provide a docker image for setting up the building and testing environment so others do not need to install a lot things when trying to build and test. Thanks. Shuai Liu <serverg...@gmail.com> 于2022年7月28日周四 21:37写道： > Thanks Justin. > > Best Regards, > serverglen > > > Justin Mclean <jus...@classsoftware.com> 于2022年7月28日周四 17:15写道： > > > Hi, > > > > +1 binding > > > > I checked: > > - incubating in name > > - signatures and hashes are good > > - LICENSE and NOTISE are fine > > - no unexpected binary file > > - all needed file have ASF headers > > - I didn’t build from source as I don’t have a suitable setup > > > > It would be nice if the README.md provided compile instructions for this > > version as well. > > > > Kind Regards, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
