Hi li gang, thanks for your valuable suggestions! For files [1-2], we declare the license information for these files in NOTICE and maintain its license in licenses/LICENSE.redis, For files [3-5], we will fix them as soon as possible.
Best, Twice On Tue, Feb 21, 2023 at 11:57 PM Liang Chen <chenliang...@apache.org> wrote: > Dear > > +1(binding), carry my vote from PPMC > > Regarding > Liang > > 在 2023年2月21日星期二，li gang <lgcar...@apache.org> 写道： > > > +1(binding),there are some issues that need to be fixed for the next > > release. > > I checked > > - Files have the word incubating in their name. > > - Checksums and signatures are valid. > > - DISCLAIMER,LICENSE and NOTICE files exist. > > - NOTICE year needs to update. > > > > LICENSE is missing license information on this file [1-5]. > > And the files [3-5] should not have an ASF header. > > 1.src/types/geohash.h > > 2.src/types/geohash.cc > > 3.src/common/rand.h > > 4.src/common/rocksdb_crc32c.h > > 5.src/storage/batch_debugger.h > > > > Pengbo Cai <caipen...@apache.org> 于2023年2月19日周日 15:24写道： > > > > > Hello Incubator PMC, > > > > > > The Apache Kvrocks community has voted and approved the release of > Apache > > > Kvrocks(incubating) 2.3.0-rc2. We now kindly request the IPMC members > > > review and vote for this release. > > > > > > We modified some of the issues about license that were raised in the > rc1 > > > vote, please refer to rc1 thread: > > > https://lists.apache.org/thread/q11wxgg3hdw694w5csf43trgv7yvj2jt > > > > > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as > > the > > > storage engine and is compatible with Redis protocol. The current > release > > > provides many new features, many improvements and fixes many bugs. > > > > > > Kvrocks community vote thread: > > > *https://lists.apache.org/thread/n2tv349f3w31yshofktgsx3drc1svc9r > > > <https://lists.apache.org/thread/n2tv349f3w31yshofktgsx3drc1svc9r>* > > > > > > Kvrocks community vote result thread: > > > *https://lists.apache.org/thread/nm9ythpw3txqwyg6r538h7rlqszw17dh > > > <https://lists.apache.org/thread/nm9ythpw3txqwyg6r538h7rlqszw17dh>* > > > > > > The release candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/ > > > > > > This release has been signed with a PGP available here: > > > https://downloads.apache.org/incubator/kvrocks/KEYS > > > > > > Git tag for the release: > > > *https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0-rc2 > > > <https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0-rc2>* > > > > > > Docker image: > > > https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256- > > > 5e75345ae8193619cb7d92daea180f1d89c2024662f4858ec38adc02b49131b0 > > > <https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256- > > 5e75345ae8193619cb7d92daea180f1d89c2024662f4858ec38adc02b49131b0> > > > > > > Build guide can be found at: > > > https://github.com/apache/incubator-kvrocks#build > > > > > > The vote will be open for at least 72 hours or until the necessary > number > > > of votes is reached. > > > > > > Please vote accordingly: > > > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0-rc2 > > > [ ] +0 > > > [ ] -1 Do not approve (please specify the reason) > > > > > > > > > Thanks, > > > Pengbo Cai > > > > > > > > > -- > > > > > > ------------------------------ > > Best Regards > > > > DolphinScheduler PMC > > Gang Li 李岗 > > > > lgcar...@apache.org > > >
