+1 （binding） I checked: - incubating in name - signatures and hashes are fine - disclaimer exists - license and notice files look good - file have correct ASF headers if necessary
On Thu, Jul 20, 2023 at 6:39 PM tison <wander4...@gmail.com> wrote: > > +1 (binding) > > I checked: > - incubating in name > - signatures and checksum are file > - No unexpected binary files > - LICENSE and NOTICE are fine > - DISCLAIMER file exists > - Compiled from source > > Best, > tison. > > > Xuanwo <xua...@apache.org> 于2023年7月18日周二 13:20写道： > > > Thanks for the VOTE and verify! > > > > > 1. ./bindings/python/python/opendal/layers.pyi > > > > Tracked at https://github.com/apache/incubator-opendal/issues/2662, we > > expect to fix it in next release. > > > > > 2. ./examples/rust/01-init-operator/src/main.rs > > > > Those files are served as rust examples docs, we plan to remove them in > > release. > > > > On Tue, Jul 18, 2023, at 13:10, Justin Mclean wrote: > > > Hi, > > > > > > +1 (binding) > > > > > > I checked: > > > - incubating in name > > > - signatures and hashes are file > > > - No unexpected binary files > > > - LICENSE and NOTICE are fine > > > - a few files don’t have ASF headers e.g. [1][2] > > > > > > I don’t have an environment set up to compile this, but including some > > > easy to find instructions in the release on how to compile is a good > > > idea. > > > > > > Kind Regards, > > > Justin > > > > > > 1. ./bindings/python/python/opendal/layers.pyi > > > 2. ./examples/rust/01-init-operator/src/main.rs > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > -- > > Xuanwo > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > -- Best wishes！ CalvinKirs --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
