-1 (binding)
I had voted +1 on the dev list but I am changing my vote in light of the header
issues that Calvin discovered.
A typical java file in Baremaps has this header:
/*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
* or implied. See the License for the specific language governing permissions
and limitations under
* the License.
*/
But should have the following:
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to you under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Julian
> On Sep 25, 2023, at 7:06 AM, Calvin Kirs <k...@apache.org> wrote:
>
> Hi,
>
> sorry for my late check. I've been a little busy lately.
>
> -1 (binding)
>
> I checked:
>
> - checked the asc and sha checksums
> - incubating in the name
> - LICENSE and NOTICE and DISCLAIMER-WIP present
> - can build from source
> - no unexpected compiled binaries in the source distribution
>
> I don't have any other questions, but our license header is missing
> something crucial------Licensed to the Apache Software Foundation
> (ASF) under one or more contributor license agreements.
>
> I think we've already filed the ICLA/CLA, so this statement is important.
>
> On Mon, Sep 25, 2023 at 5:10 AM PJ Fanning <fannin...@apache.org> wrote:
>>
>> +1 (binding) despite minor issues in DISCLAIMER-WIP
>>
>> * checked the asc and sha checksums
>> * incubating in name
>> * LICENSE and NOTICE and DISCLAIMER-WIP present
>> * can build from source
>> * no unexpected compiled binaries in source distribution
>>
>> The DISCLAIMER-WIP has not fixed a URL present in the file
>> - https://incubator.apache.org/projects/Apache Podling-Name.html
>> - this should probably be https://incubator.apache.org/projects/baremaps.html
>>
>> Also, you should possibly remove the line in DISCLAIMER-WIP about the
>> releases not being voted on. Or could you be more specific about which
>> releases were not voted on?
>> - Releases may not have been voted on by the community.
>>
>>
>>
>>
>>
>> On 2023/09/23 14:25:51 Bertil Chapuis wrote:
>>> Hello Everyone,
>>>
>>> This is a call for a vote to release Apache Baremaps 0.7.2 (incubating),
>>> release candidate 2. Apache Baremaps is a toolkit and a set of
>>> infrastructure components for creating, publishing, and operating online
>>> maps.
>>>
>>> We would like to request the Incubator PMC members to review and vote on
>>> this incubator release. The Apache Baremaps community has voted on and
>>> approved a proposal to release Apache Baremaps 0.7.2 (incubating). The
>>> result of the vote can be consulted here:
>>> https://lists.apache.org/thread/vp4sfk5grtcwy8h6f5rhvyj2cw96rp1r
>>>
>>> You can read the release notes here:
>>> https://github.com/apache/incubator-baremaps/releases/tag/v0.7.2-rc2
>>>
>>> The commit to be voted upon:
>>> https://github.com/apache/incubator-baremaps/tree/v0.7.2-rc2
>>>
>>> Its hash is f09223fbaaccca3f2c7faa1374bc45eb6aa2aee4.
>>>
>>> Its tag is v0.7.2-rc2.
>>>
>>> The artifacts to be voted on are located here:
>>> https://dist.apache.org/repos/dist/dev/incubator/baremaps/0.7.2-rc2/
>>>
>>> The hashes of the artifacts are as follows:
>>> 8e55818d13b3e8408c37471ac287c7db08e0a83806381901eadef554839d39799bf2bc1f95d5ac2c69541cde6fce4e477555a56d1ec5662d66b13a0f39f6a369
>>> ./apache-baremaps-0.7.2-incubating-src.tar.gz
>>> 8919279274750f76f1346c810f3f9325e2fc65ef332f756533fdd90351eef053e9ef75004846b1e5e98e2b8326bd44bad60f744756fceb8c221f2914d2fa8709
>>> ./apache-baremaps-0.7.2-incubating-bin.tar.gz
>>>
>>> Release artifacts are signed with the following key:
>>> http://people.apache.org/keys/committer/bchapuis.asc
>>> https://downloads.apache.org/incubator/baremaps/KEYS
>>>
>>> The README file for the src distribution contains instructions for building
>>> and testing the release.
>>>
>>> Please vote on releasing this package as Apache Baremaps 0.7.2.
>>>
>>> The vote is open for the next 72 hours and passes if a majority of at least
>>> three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Baremaps 0.7.2
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>> Best,
>>>
>>> Bertil
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>
>
> --
> Best wishes！
> CalvinKirs
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
