> In short, please use Java 8 or 11(we use 8 for releasing) to build the
> source code with the command `./build/make-distribution.sh
> --sbt-enabled --release`.

Thanks!

I have confirmed that the build passed with Java 8 by

./build/make-distribution.sh --sbt-enabled --release  1536.31s user 44.19s 
system 619% cpu 4:15.18 total

I'm now casting my vote to +1 non-binding.

On Mon, Jan 22, 2024, at 01:14, Cheng Pan wrote:
> Xuan wo, thanks for voting and verification.
>
> The provided gist indicates you are using Java 21 with the command
> `sbt compile` to build the source code, which does not match the
> assumption.
>
>> :) sbt compile
>> [info] welcome to sbt 1.9.4 (N/A Java 21.0.2)
>
> The attached link in the voting mail provides the System Requirements
> and build guidelines
>
>> The SBT build documentation is available at 
>> https://celeborn.apache.org/docs/latest/developers/sbt/.
>
>> ... supports Scala 2.11/2.12/2.13 and Java 8/11/17.
>
> In short, please use Java 8 or 11(we use 8 for releasing) to build the
> source code with the command `./build/make-distribution.sh
> --sbt-enabled --release`.
>
> Thanks,
> Cheng Pan
>
> On Mon, Jan 22, 2024 at 12:38 AM Xuanwo <xua...@apache.org> wrote:
>>
>> Hi, Fu Chen
>>
>> -1 non-binding
>>
>> [x] Download links are valid
>> [x] Checksums and signatures
>>
>> gpg: Signature made Thu 18 Jan 2024 09:18:05 PM CST
>> gpg:                using RSA key 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>> gpg: checking the trustdb
>> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
>> gpg: depth: 0  valid:  18  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 18u
>> gpg: next trustdb check due at 2024-05-25
>> gpg: Good signature from "Fu Chen (For Kyuubi release) <fc...@apache.org>" 
>> [ultimate]
>> apache-celeborn-0.4.0-incubating-source.tgz
>> gpg: Signature made Thu 18 Jan 2024 09:06:45 PM CST
>> gpg:                using RSA key 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>> gpg: Good signature from "Fu Chen (For Kyuubi release) <fc...@apache.org>" 
>> [ultimate]
>>
>> [x] LICENSE/NOTICE/DISCLAIMER files exist
>> [x] NO unexpected binary files
>> [x] Source files have ASF headers
>> [-] Compile failed on archlinux x86_64
>>
>> [info] Non-compiled module 'compiler-bridge_2.12' for Scala 2.12.15. 
>> Compiling...
>> error:
>>   bad constant pool index: 0 at pos: 48461Incremental 0s
>>      while compiling: <no file>
>>         during phase: globalPhase=<no phase>, enteringPhase=<some phase>
>>      library version: version 2.12.15
>>     compiler version: version 2.12.15
>>
>> The full log could be found at 
>> https://gist.github.com/Xuanwo/d39354b53e02776cbdf1ae53d74f5e4f
>>
>>
>> On Mon, Jan 22, 2024, at 00:24, Fu Chen wrote:
>> > Hi IPMC,
>> >
>> > This is a call for a vote to release Apache Celeborn (Incubating)
>> > 0.4.0-incubating-rc4
>> >
>> > The Apache Celeborn community has voted on and approved a proposal to
>> > release Apache Celeborn (Incubating) version 0.4.0-incubating-rc4.
>> > We now kindly request the Incubator PMC members review and vote on this
>> > incubator release.
>> >
>> > celeborn@dev vote thread:
>> >
>> > https://lists.apache.org/thread/w91n2vgwts06gskoc5y19gl49myjm1jq
>> >
>> > celeborn@dev vote result thread:
>> >
>> > https://lists.apache.org/thread/7ylzdq6htzvlnnjzb5lhdd1nsfv4cjmn
>> >
>> > The git tag to be voted upon:
>> >
>> > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
>> >
>> > The git commit hash:
>> > 8bc07466dd85a90216820617015e329fb806c7dd
>> >
>> > The source and binary artifacts can be found at:
>> >
>> > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
>> >
>> > The staging repo:
>> >
>> > https://repository.apache.org/content/repositories/orgapacheceleborn-1051
>> >
>> > Fingerprint of the PGP key release artifacts are signed with:
>> > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>> >
>> > My public key to verify signatures can be found in:
>> >
>> > https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>> >
>> > The vote will be open for at least 72 hours or until the necessary
>> >
>> > number of votes are reached.
>> >
>> > Please vote accordingly:
>> >
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove (and the reason)
>> >
>> > Checklist for release:
>> >
>> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>> >
>> > Steps to validate the release:
>> >
>> > https://www.apache.org/info/verification.html
>> >
>> > Please be aware that there has been a transition in the Celeborn project's
>> > build tool, shifting from Maven to SBT. The SBT build documentation is
>> > available at https://celeborn.apache.org/docs/latest/developers/sbt/.
>> >
>> > For illustrative purposes:
>> >
>> > Packaging the project
>> > ```
>> > ./build/sbt clean package
>> > ```
>> >
>> > Creating the distribution
>> > ```
>> > ./build/make-distribution.sh --sbt-enabled --release
>> > ```
>> >
>> > Regards,
>> > Fu Chen
>>
>> --
>> Xuanwo
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
>> For additional commands, e-mail: general-h...@incubator.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org

-- 
Xuanwo

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to