Thanks Tison,

The files with the license header that mentions Akka is put on files
that are derived from Akka. The standard ASF header is put on new
files.

https://issues.apache.org/jira/browse/LEGAL-626 gives the background
to the Akka header.


On Thu, 25 Jan 2024 at 10:46, tison <wander4...@gmail.com> wrote:
>
> +1 binding
>
> + Download link valid
> + Checksum and signature match
> + LICENSE, NOTICE and DISCLAIMER exist
> + Can build from source with: sbt compile
>
> Find some binary files for testing in the release. While I don't think
> it's a release blocker, you may try to generate it on the fly:
>
> ./s3/src/test/resources/keystore.jks
> ./google-cloud-pub-sub-grpc/src/main/resources/GSR2.crt
> ./file/src/test/resources/nested-sample.tar
>
> Also, I find the license header is something the ASF "standard" one,
> but otherwise:
>
> > Licensed to the Apache Software Foundation (ASF) under one or more
> > license agreements; and to You under the Apache License, version 2.0:
> >
> >   https://www.apache.org/licenses/LICENSE-2.0
> >
> > This file is part of the Apache Pekko project, which was derived from Akka.
>
> Is there any reason for different styles? How do you check that the
> license headers are properly included?
>
> Best,
> tison.
>
> PJ Fanning <fannin...@apache.org> 于2024年1月25日周四 17:05写道:
> >
> > Hi everyone,
> >
> > We still need 1 more binding vote on this vote before we can proceed with a 
> > release.
> >
> > Would anyone have time to review this RC? It includes a few bug fixes that 
> > would be good to get released.
> >
> > Thanks,
> > PJ
> >
> > On 2024/01/21 12:01:08 PJ Fanning wrote:
> > > Thanks Xuanwo. I have created PRs to update our NOTICE files.
> > >
> > > On 2024/01/21 08:53:47 Xuanwo wrote:
> > > > +1 non-binding
> > > >
> > > > [x] Download links are valid.
> > > > [x] Checksums and signatures.
> > > >
> > > > apache-pekko-connectors-1.0.2-incubating-src-20240109.tgz
> > > > gpg: Signature made Tue 09 Jan 2024 08:45:04 PM CST
> > > > gpg:                using RSA key 
> > > > 6BA4DA8B1C88A49428A29C3D0C69C1EF41181E13
> > > > gpg: checking the trustdb
> > > > gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> > > > gpg: depth: 0  valid:  16  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 16u
> > > > gpg: next trustdb check due at 2024-05-25
> > > > gpg: Good signature from "PJ Fanning (GitHub noreply address) 
> > > > <pjfann...@users.noreply.github.com>" [ultimate]
> > > > gpg:                 aka "PJ Fanning <fannin...@yahoo.com>" [ultimate]
> > > > gpg:                 aka "PJ Fanning (http://www.apache.org/) 
> > > > <fannin...@apache.org>" [ultimate]
> > > >
> > > > [x] LICENSE/NOTICE/DISCLAIMER files exist
> > > >
> > > > nit: The NOTICE file seems not mention that Pekko is an incubating 
> > > > project.
> > > >
> > > > [x] No unexpected binary files
> > > > [x] Source files have ASF headers
> > > > [x] Can compile from source
> > > >
> > > > [success] Total time: 239 s (03:59), completed Jan 21, 2024, 4:53:04 PM
> > > > sbt compile  459.14s user 14.09s system 154% cpu 5:05.48 total
> > > >
> > > > Build success on archlinux x86_64
> > > >
> > > > BTW, sbt is much faster than mvn!
> > > >
> > > > On Sat, Jan 13, 2024, at 03:20, PJ Fanning wrote:
> > > > > Hello Incubator Community,
> > > > >
> > > > > This is a call for a vote to release Apache Pekko(incubating)
> > > > > Connectors version 1.0.2-RC1.
> > > > >
> > > > > The discussion thread:
> > > > > https://lists.apache.org/thread/31tvbff0j880v3kvpmdq3st32dkynvnb
> > > > >
> > > > > Pekko PPMC Vote Thread
> > > > > https://lists.apache.org/thread/nosrvwphtwmcg7dw9pz6y1qbtm3zhgpn
> > > > >
> > > > > Pekko PPMC Vote Result
> > > > > https://lists.apache.org/thread/n27jqcy4160981lhdr01ljqs0c31nshh
> > > > >
> > > > > The release candidate:
> > > > >
> > > > > https://dist.apache.org/repos/dist/dev/incubator/pekko/CONNECTORS-1.0.2-RC1/
> > > > >
> > > > > This release has been signed with a PGP key, available here:
> > > > >
> > > > > https://dist.apache.org/repos/dist/release/incubator/pekko/KEYS
> > > > >
> > > > > Release Notes:
> > > > >
> > > > > https://github.com/apache/incubator-pekko-connectors/pull/310/files
> > > > >
> > > > > Git branch for the release:
> > > > >
> > > > > https://github.com/apache/incubator-pekko-connectors/tree/v1.0.2-RC1
> > > > > Git commit ID: 8b4d6f7db0d1c8e1482f8fcd913022ef7fe357ab
> > > > >
> > > > > Please download, verify, and test.
> > > > >
> > > > > We have also staged jars in the Apache Nexus Repository. These were
> > > > > built with the same code
> > > > > as appears in this Source Release Candidate. We would appreciate if
> > > > > users could test with these too.
> > > > > If anyone finds any serious problems with these jars, please also
> > > > > notify us on this thread.
> > > > >
> > > > > https://repository.apache.org/content/groups/staging/org/apache/pekko/
> > > > >
> > > > > In sbt, you can add this resolver.
> > > > >
> > > > > resolvers += "Apache Pekko Staging" at
> > > > > "https://repository.apache.org/content/groups/staging";
> > > > >
> > > > >
> > > > > The vote will be left open for at least 72 hours.
> > > > >
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > >
> > > > > To learn more about Apache Pekko, please see https://pekko.apache.org/
> > > > >
> > > > > Checklist for reference:
> > > > >
> > > > > [ ] Download links are valid.
> > > > > [ ] Checksums and signatures.
> > > > > [ ] LICENSE/NOTICE files exist
> > > > > [ ] No unexpected binary files
> > > > > [ ] Source files have ASF headers
> > > > > [ ] Can compile from source
> > > > >
> > > > > To compile from the source, please refer to:
> > > > >
> > > > > https://github.com/apache/incubator-pekko/blob/main/README.md#building-from-source
> > > > >
> > > > > Some notes about verifying downloads can be found at:
> > > > >
> > > > > https://pekko.apache.org/download.html#verifying-downloads
> > > > >
> > > > >
> > > > > Here is my +1 (binding).
> > > > >
> > > > > Thanks,
> > > > > PJ Fanning
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > > --
> > > > Xuanwo
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > > For additional commands, e-mail: general-h...@incubator.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to