Hi JB, Thanks for your reply!
Best, Dianjin Wang On Thu, Jul 10, 2025 at 1:55 AM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > > +0 (binding) > - LICENSE and NOTICE are good (nit: NOTICE should not contain > Greenplum and PostgreSQL mention because it's not coming from notice > from Apache dependency and it's already covered in the LICENSE) Got it. So we can remove them from the NOTICE file and leave the Cloudberry part only. > - To Be Fixed: a lot of files don't contain the ASF header. For > instance, md files should have the ASF header, the build file like > Makefile, python file, .... Can you please make a full pass and fix > that ? The code copied from other projects should also keep the > original header. Thanks. Will check them again and add the license header to the md and other files originally created by the Cloudberry community. For the code copied from other projects, I believe we keep the original header unchanged. One more question, could we fix these issues in the later release, or must we complete them in this release? Thanks for your review again! --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
