*+1 (Binding)* I have reviewed the release candidate for *Apache <ProjectName> <Version>* and performed the required checks. Based on my review, I am casting my *+1 (Binding)* vote.
*Checklist reference (as per verification):* - ✅ Checked *“Incubating”* is present in the name (where applicable). - ✅ Verified *download links* are valid and accessible. - ✅ Verified *checksums (SHA512)* and *signatures (ASC)*. - ✅ Confirmed presence of *LICENSE*, *NOTICE*, and *DISCLAIMER* files. - ✅ Ensured there are *no unexpected binary files*. - ✅ Confirmed *all source files include ASF headers*. - ✅ Successfully *built and tested from source*. Everything looks good to me. On Wed, Oct 8, 2025 at 6:08 PM Jean-Baptiste Onofré <[email protected]> wrote: > +0 (binding) > > - the version doesn't include -incubating (sf_hamilton-1.89.0, PKG-INFO) > - hash and checksum are good > - DISCLAIMER is there > - LICENSE/NOTICE are good > - ASF header are present in expected files > - no binary file found in the source distribution > > Is it possible to at least keep the -incubating in the name and/or version > ? > > Thanks, > Regards > JB > > On Sat, Oct 4, 2025 at 9:16 AM Stefan Krawczyk > <[email protected]> wrote: > > > > Hi all, > > > > This is our first vote on the general incubator mailing list. > > > > This is a call for a vote on releasing Apache hamilton 1.89.0-incubating, > > release candidate 1. > > > > This release includes the following changes: > > https://github.com/apache/hamilton/releases/tag/v1.89.0-incubating-RC1 > > > > The artifacts for this release candidate can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/hamilton/1.89.0-RC1 > > > > The Git tag to be voted upon is: v1.89.0-incubating-RC1. > > > > The release hash is: > > > > b50355e5bacd3ba746f80072fe6c83a786f44b0a - this just adds the verison > bump > > (not on main) - and is what the tag refers to. Once approved this will be > > added to main. > > > > > > b2bee61b7c63af9c44114384710cd2e0efecffca -this is the functional commit > > reference. > > > > Release artifacts are signed with the following key: > > > > FE668E857E89A11C5E5C000CA8D3D15600545C61 > > > > The KEYS file is available at: > > https://downloads.apache.org/incubator/hamilton/KEYS > > > > > > *Please download, verify, and test the release candidate.* > > *Note: we have two "versions" of the .tar.gz and .whl files. *Their > > contents should be identical, except for the file name. We plan to > publish > > the sf_hamilton ones to the existing pypi destination. If instead we > should > > not include these in this process, and instead post-process the apache > > ones, then we could do that too... > > > > *For testing*, please run some of the examples, scripts/qualify.sh > > <https://github.com/apache/hamilton/blob/main/scripts/qualify.sh>has > > a sampling of them to run. Note: you'll likely want to install the > optional > > dependencies selectively, or just go ahead and install everything > required > > for test. > > Also if an example doesn't work, double check the README for set up > > instructions. > > > > The vote will run for a minimum of 72 hours, likely more given that it's > > the weekend. > > > > Please vote: > > > > [ ] +1 Release this package as Apache hamilton 1.89.0-incubating > > [ ] +0 No opinion > > [ ] -1 Do not release this package because... (Please provide a reason) > > > > *Checklist reference (please include in your vote):* > > [ ] Incubating in name (where applicable). > > [ ] Download links are valid. > > [ ] Checksums and signatures. > > [ ] LICENSE/NOTICE/DISCLAIMER files exist > > [ ] No unexpected binary files > > [ ] All source files have ASF headers > > [ ] Can use from source > > > > *Known things* that were found from podling vote: > > * License lists file that doesn’t exist > > - contrib/hamilton/contrib/user/skrawcz/customize_embeddings/__init__.py > > * Some files missing Apache headers - in hamilton/dataflows/template > > and some .md files > > * There are generated files from the build process that we understand > don't > > need the license header, e.g. PKG_INFO... > > > > > > On behalf of the Apache hamilton PPMC, > > > > Stefan > > > > Note: this email and build is based on the release helper script > > < > https://github.com/apache/hamilton/blob/main/scripts/apache_release_helper.py > > > > we are curating. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
