-1 (binding)

I checked:
- source distribution
-- incubating is not in the name/version
-- checksum and signature are good
-- DISCLAIMER is not present in the source distribution
-- LICENSE is not correct: you bundle a bunch of modules (copying
source) in geaflow-dashboard (node_modules). I guess that should be
done at build but not bundle in the source distribution. If so, the
LICENSE has to mention all these modules
-- Can you clarify what LEGAL.md means ?
-- No NOTICE
-- ASF header is present in expected file
-- No binary found in the source distribution

To be fixed:
1. I would suggest removing the node_modules from the
geaflow-dashboard, it should be "assembly" at build time (not part of
the source distribution).
2. Add incubating in name/version
3. Add DISCLAIMER
4. I guess LICENSE/NOTICE will be good after (1)

Happy to help if needed.

Thanks !
Regards
JB

On Tue, Oct 28, 2025 at 8:03 AM Fengjun Lv <[email protected]> wrote:
>
> +1 approve
>
> The following items I have checked below:
>
> [x] Download links are valid.
> [x] Checksums and signatures.
> [x] LICENSE files exist.
> [ ] No unexpected binary files.
> [x] All source files have ASF headers.
> [ ] Can compile from source.
>
> And I notice that this is the GeaFlow project's first community release 
> candidate, so we encourage all community members to participate in the vote.
>
> On 2025/10/28 06:44:02 Qiang Zhou wrote:
> > * We apologize for resending this message due to the format issues. The
> > last email sent is invalid. *
> >
> > Hi everyone,
> >
> > The Apache GeaFlow community has voted and approved the release of Apache
> > GeaFlow v0.7.0-rc1 (Incubating). We are now kindly requesting the IPMC
> > members to review and vote for this release.
> >
> > Apache GeaFlow community vote thread:
> >
> > -  https://lists.apache.org/thread/ryw8xwlgtc920xrk9y90gmffwmrrsq06
> >
> > Vote result thread:
> >
> > - https://lists.apache.org/thread/b3rz8hmhtqdncjhs5m3qylg1ypmkpxr8
> >
> > This corresponds to the tag: v0.7.0-rc1.
> >
> > - https://github.com/apache/geaflow/commits/v0.7.0-rc1
> > -
> > https://github.com/apache/geaflow/tree/8c1c52b307dec5d3f82481e3000c72e698b97fc7
> >
> > The release zip package, signature, and checksum are here:
> >
> > - https://dist.apache.org/repos/dist/dev/incubator/geaflow/v0.7.0-rc1/
> > <https://dist.apache.org/repos/dist/dev/incubator/geaflow/v0.7.0-rc1/>
> >
> > You can find the KEYS file here:
> >
> > - https://dist.apache.org/repos/dist/dev/incubator/geaflow/KEYS
> > <https://dist.apache.org/repos/dist/dev/incubator/geaflow/KEYS>
> >
> > The Maven staging repository:
> >
> > -   https://repository.apache.org/content/repositories/orgapachegeaflow-1007
> >
> > Please download, verify and test.
> >
> > The vote is open for at least 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > To learn more about Apache GeaFlow, please see https://geaflow.apache.org/.
> >
> > Kind Regards,
> > loogn
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to