On 2026/02/22 08:05:00 Jean-Baptiste Onofré wrote: > +1 (binding) > > I would suggest clarifying the source distribution NOTICE file for the next > release. > > I checked: > - source distribution > -- incubating is in the name/version > -- signature and checksum are good > -- DISCLAIMER is present > -- LICENSE and NOTICE are good. nit: the copyright year is still 2025 in > the NOTICE. Also, I think the mention of the DEPENDENCIES file is not > required in the NOTICE, as this NOTICE is for source distribution (so code > you have copied from another project). I would suggest clarifying this for > the next release (DEPENDENCIES mention is for a binary distribution NOTICE > in your case I guess). > -- Several files don't have ASF header (md files, properties files, go.mod > files, ...). It's not a blocker as it's not "pure" code source files, I > just wanted to inform :) > -- No binary/compiled file found in the source distribution. > > Regards > JB
Thank you for the additional info, JB, we'll look at the additional files that might be missing an ASF header and check which allow additional comments on top. As for .md files, I'm not sure if it's even possible to include custom headers/comments/metadata on top without rendering it fully on GitHub/Docs along with the rest of the content. +1 (non-binding) from me --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
