On Wed, May 6, 2026 at 5:03 AM Justin Mclean <[email protected]> wrote:
> I noticed that your release-checking scripts don't seem to be up to date. > This is not a goal. The scripts under util/ are intended to aide the manual checking of releases, and sharing them within the team is intended to be helpful and convenient, but it is not a goal that they work out of the box or that their checks would represent a complete list of things to check. In fact we interpreted the spirit of the ASF release voting process such that it is considered a feature that every committer and contributor does it slightly differently and ends up finding different things. I do expect to update at least one of them periodically, for example now to make sure the dist/release vs dist/dev URLs are used in the correct places > Also, your download page at otava.apache.org/docs/download/ links > directly to dist.apache.org for artifacts rather than using closer.lua; > this needs to be fixed. [1] > Looked into this: All of our previous releases have some mixup between https://dist.apache.org/repos/dist/dev/incubator/otava/ and https://dist.apache.org/repos/dist/release/incubator/otava/ and as a result none of the previous releases are actually in the dist/release repository, and therefore also not show up under closer.lua or downloads.apache.org. -> I'll file a ticket to address this once hopefully 0.8.0 is released into the right channel. > Your GitHub releases are missing an incubation disclaimer, as is your PyPI > release. This was discussed on this list recently and needs to be fixed. > > I'm unsure what you mean by "GitHub releases"? The latest release on GitHub is 0.7.0-incubating (https://github.com/apache/otava/releases) and it contains a DISCLAIMER file addressing the incubating issue. Similarly in the files now uploaded to the svn repo but not yet the github release page, the official source release contains a DSICLAIMER file. For pypi/ the source release contains the same DISCLAIMER file, and the *.whl files include the disclaimer at the end of their METADATA file So by my count the disclaimer is present in all release artifacts? > Also you want to update the year in your NOTICE file. Submitted PR. *** Thanks for the review comments. henrik -- *nyrkio.com <http://nyrkio.com/>* ~ *Continuous Benchmarking as a Service* Henrik Ingo, CEO [email protected] LinkedIn: www.linkedin.com/in/heingo +358 40 569 7354 Twitter: twitter.com/h_ingo
