I agree with Jon in that when people agree to become a Committer to a subproject they agree to follow the rules of that subproject, the Jakarta project, and the Apache Software Foundation.
As it stands, each subproject is entitled to document their own coding conventions. When none are specified, then the default Jakarta guidelines apply. I believe that PMC members are obligated to remind people of the rules. It is up to the Committers to a subproject to see that the code is changed, but it is our job to point out the transgression. (In the same way that GUMP points out other technical problems.) Of course, other members of the community are also invited to help us watch our collective backs. Personally, I believe that everyone here is a consummate professional, or wants to be, and following the coding conventions of your codebase is a hallmark of professionalism. When I screw up, I certainly want someone to point it out to me, as Jon has started to do. A word to wise should be sufficient. As Sam mentioned, it is unlikely that the PMC or ASF is going to shut down a codebase for not following their conventions. But we should exercise our obligation to nag people until the commits come into compliance or the conventions for the subproject are amended. AFAIK, a change to a subproject coding conventions would be a Product Change. -- Ted Husted, Husted dot Com, Fairport NY USA. -- Building Java web applications with Struts. -- Tel +1 585 737-3463. -- Web http://www.husted.com/struts/ Jon Scott Stevens wrote: > > It is amazing to me...with all the discussion about coding styles and > following them, we still have people committing code that doesn't follow > what rules we do have... > > on 1/3/02 11:00 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > > Re: cvs commit: jakarta-commons/logging/src/java/org/apache/commons/logging > SimpleLog.java > > > + if(_showtime) { > > <http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html#367> > > "Variable names should not start with underscore _ or dollar sign $ > characters, even though both are allowed." > > <http://jakarta.apache.org/site/source.html> > > "All Java Language source code in the repository must be written in > conformance to the "Code Conventions for the Java Programming Language as > published by Sun." > > -jon > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
