On 6/15/06, sebb <[EMAIL PROTECTED]> wrote:
On 15/06/06, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> On 6/15/06, sebb <[EMAIL PROTECTED]> wrote:
> > On 15/06/06, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> > > On 6/15/06, sebb <[EMAIL PROTECTED]> wrote:
> > > > Were there any errors reported by the Ant build?
> > > >
> > > > Some while ago I added a task to strip off the extra spaces. Did this
> > > > complete successfully?
> > > >
> > > > The last time there were space differences, there was an error that
> > > > stopped the replace working, but it had not been noticed (there's
> > > > quite a lot of output generated).
> > > >
> > > > Or perhaps it did not run - it depends on the Java version, as I did
> > > > not want to run it if it was not necessary. You could try fixing the
> > > > file to always run the replace.
> > >
> > > That was it - I ran it originally using JDK 1.5.0_06 and the replace
> >
> > Which vendor/OS?
>
> Sun/W2K
>
> > > only runs for JDK 1.4 - when I switch to JDK 1.4 or change the
> > > build.xml to run it for any JDK version then it only generates changes
> > > for what I expected.
> > >
> > > Was there a reason this was targeted only at JDK 1.4? Also I don't
> > > understand why its doing this replace anyway - doesn't the space make
> > > it valid XHTML?
> > >
> >
> > The space does not affect validity.
> >
> > What I found originally was that there was a difference between the
> > output produced by 1.4 and 1.5, in that 1.4 adds an extra space before
> > the terminating "/>". I'm not sure that it does this for every tag, so
> > the only way I could see to make sure that the output was the same for
> > both was to remove the extra spaces.
> >
> > It seemed unnecessary to strip the spaces for 1.5, so I made it conditional.
> > Later I discovered that some VMs other than Sun added the spaces, so I
> > changed the check to look for Sun 1.5 only.
> >
> > Seems like you have found that the replace needs to be done always.
>
> Yup, looks that way for it to be consistent. You want to do it or shall I?
If you don't mind...
OK, done.
> Niall
>
> P.S. Thx for the help on this - just trying to add an announcement :-)
>
No problem...
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
