I wrote some of my comments based on a earlier memory of the article and see that some of them are no longer as relevant.
* The current intro/link to stdlib.ijs is good, the only issue being that as stdlib.ijs changes, the wiki page describing it will need to be updated as well. An alternative might be to link to the Trac page with the source scripts that still contains the comments. http://www.jsoftware.com/trac/base7/browser/trunk/main/main * The current version now does a better job of separating out suggested customizations from the standard environment. I'd still be tempted not to use those customizations (e.g. "handler") in your simple app though. Some additional comments: There are a number of definitions in handy.ijs that seem redundant to me in that there are standard utilities shipped with J. nub - J has a inbuilt primitive for this ( ~. ) there are standard names for your reset, si, stop defined in the debug script (open 'debug') reset -: dbr si -: dbs stop -: dbss TB - defined as TAB in stdlib ope - how does this differ to open ? listnameswithprefix - this seems to be the same as nl~ Not saying it's better, but I'd normally write: calc_num1_button=: digit bind 1 instead of: calc_num1_button=: 1&digit IMO it is clearer to see that digit's argument will always be 1. I agreed with Brian that I missed the "equals" button in the original calc.ijs. Now I miss the "plus" button. It seems unintuitive to press "=" when you want to add. The current phrasing of your "blasphemous comment" has more impact but I get the feeling that your actual message is more like: "There is no need to get your head around tacit definition". The fact is that many of the button handlers in the calc script use tacit code! I suppose it comes down to whether you think that being provocative rather than reassuring will help get your message across best. > From: Sherlock, Ric > Sent: Monday, 1 November 2010 11:51 > > I would suggest that you highlight to your reader any of the things > that you have found useful additions to the J environment and show them > how they can add them to their own installed environment, that way it > will be clear that these are things that they shouldn't expect to be > available in every J session. Alternatively you could concentrate on > introducing the reader to the J environment as it is and save those > customizations for a separate article - "Tips and tricks for > customizing/improving the J environment". > > I think in an earlier edition you mentioned that the words noun, verb, > conjunction etc were all defined in the stdlib.ijs. The J6.02 version > of this script contains a lot of comments and descriptions, I'd > recommend suggesting to the reader to open and inspect the script: > open '~system/main/stdlib.ijs' > > These comments are (unfortunately IMO) removed from the stdlib.ijs > script, and other distributed scripts in the J701 beta. > > Thanks again for this fine contribution to the community! > > Ric > > > From: Ian Clark > > Sent: Thursday, 28 October 2010 15:28 > > > > http://www.jsoftware.com/jwiki/JinaDay > > > > Thanks to all for crits, and for provocative & instructive > > discussions. It doesn't escape me that a lot of people have really > > spent time to debug it. > > > > 1st draft done. Extensive edits. Most people's suggestions > > incorporated (I've not checked everyone's is in, but I will). Demo > app > > CALC somewhat improved, behaviour more intuitive, focus problem > > hopefully solved. Correct (?) use of the term "array" -- which has > > proved useful after all. > > > > LOBROW will need some spit&polish before final publication. Ditto > > handy.ijs. > > > > Haven't checked that all weblinks are actually used in the text. On > > the other hand there may be more that ought to be mentioned. > Virtually > > no mention of the J Primer, which IMO is an omission. > > > > Ian > > ---------------------------------------------------------------------- > For information about J forums see http://www.jsoftware.com/forums.htm ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
