> > I don't see any reason for this change -- in fact the "* 2" looks
> > buggy to me. Probably a historical relic -- the only access to the
> > dev_map bitmap that I see uses at most IB_UMAD_MAX_PORTS bits.
>
> Are you sure ? Don't issm files need a duplicated set of dev_map bits ?
Well, read the code. The only use of dev_map that I can find is
port->dev_num = find_first_zero_bit(dev_map, IB_UMAD_MAX_PORTS);
which doesn't look past bit # IB_UMAD_MAX_PORTS. Am I missing something?
> By clean up, (aside from static const), is there more than what you
> indicate below in making issm and issmdisabled share the same open/close
> routines ?
No, I just meant convert that to static const. And unify the
open/close routines. Although maybe the cleanest way to unify the
code is to leave the properties on the stack and set it up before the
call to ib_modify_port() depending on which file is being accessed.
- R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
