hi roland, ...

On Tue, May 08, 2007 at 05:58:51PM -0700, Roland Dreier wrote:
>  > GPIO interrupts which have the gpio_mask bits set are
>  > no longer unlikely.  remove the unlikely annotation in
>  > the interrupt handler and keep a shadow copy of the
>  > gpio_mask register.
> 
> A better changelog would be appreciated here... I can see deleting the
> unlikely() if it's no longer appropriate, but why keep a shadow copy
> of the register?  Because this is now a hotter path and you want to
> avoid the MMIO read?

exactly.  shall i add that and resend?

arthur
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to