OK. looks pretty good to me. One coding style violation I found:
> @@ -268,5 +265,9 @@ void ipoib_event(struct ib_event_handler
> record->element.port_num == priv->port) {
> ipoib_dbg(priv, "Port state change event\n");
> queue_work(ipoib_workqueue, &priv->flush_task);
> + } else if (record->event == IB_EVENT_PKEY_CHANGE &&
> + record->element.port_num == priv->port) {
> + ipoib_dbg(priv, "pkey change event on port:%d\n", priv->port);
> + queue_work(ipoib_workqueue, &priv->pkey_event_task);
> }
> }
This violates Breaking long lines rule again. Should be
> + } else if (record->event == IB_EVENT_PKEY_CHANGE &&
> + record->element.port_num == priv->port) {
> + ipoib_dbg(priv, "pkey change event on port:%d\n", priv->port);
> + queue_work(ipoib_workqueue, &priv->pkey_event_task);
> }
--
MST
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
