Michael S. Tsirkin wrote: >> Quoting Erez Zilber <[EMAIL PROTECTED]>: >> Subject: [PATCH 2/2] IB/iser: add backport & kernel addons for open-iscsi >> over iSER support for RHAS4 up3 and up4 >> >> >> Add the required backport patches & kernel addons for open-iscsi >> over iSER in RHAS4 up3 and up4. >> >> Signed-off-by: Erez Zilber <[EMAIL PROTECTED]> >> > > In addition to posting patches, could you pls publish a git tree to pull from, > please? This makes it easy to test-build the patch as our build system > knows how to do git checkout. > > --- > > Two comments, generally > A: Please move code from kernel_patches to kernel_addons as much > as possible. There are many places where you just add new headers, > or add #include directives, or change the function called or > remove extra parameters, all this can and should be done through addons. > > B: Please do not add code to core unless there is more than 1 user - > add it to the iser module instead. This way if there is > compilation failure there, you do not break core for people. > >
Thanks for the feedback. I will make the fixes and post a new version soon. Erez _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
