On Fri, 2007-06-22 at 01:27, Michael S. Tsirkin wrote:
> > But let's try to make this be the last ABI break.  Are we
> > pretty sure there's *nothing* else we might ever want to add to the
> > structure?  I can't think of anything right now...
> 
> It'd be easy to add some extra padding just in case ...

There are 6 bytes of reserved being added as part of the ABI change:

diff --git a/include/rdma/ib_user_mad.h b/include/rdma/ib_user_mad.h
index d66b15e..e7bf6fa 100644
--- a/include/rdma/ib_user_mad.h
+++ b/include/rdma/ib_user_mad.h
@@ -43,7 +43,7 @@
  * Increment this value if any changes that break userspace ABI
  * compatibility are made.
  */
-#define IB_USER_MAD_ABI_VERSION        5
+#define IB_USER_MAD_ABI_VERSION        6
 
 /*
  * Make sure that all structs defined in this file remain laid out so
@@ -88,6 +88,8 @@ struct ib_user_mad_hdr {
        __u8    traffic_class;
        __u8    gid[16];
        __be32  flow_label;
+       __u16   pkey_index;
+       __u8    reserved[6];
 };
 
 /**

-- Hal

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to