Sean Hefty wrote:
To support QoS within and between subnets, modify IPoIB to request
specific Traffic Class values with path record queries, using
the value associated with the IPoIB broadcast group.

Sean,

During the first post the issue of providing also the SL (and/or other params) from the broadcast group as part of the path query was raised, and I kind of failed to follow all the discussion that evolved... Can you clarify if the consensus was that based on the pkey and traffic class, the SA should return the --same-- SL (and/or other params) on this path query as of the broadcast group?

--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -468,9 +468,10 @@ static struct ipoib_path *path_rec_create(struct 
net_device *dev, void *gid)
        INIT_LIST_HEAD(&path->neigh_list);

        memcpy(path->pathrec.dgid.raw, gid, sizeof (union ib_gid));
-       path->pathrec.sgid      = priv->local_gid;
-       path->pathrec.pkey      = cpu_to_be16(priv->pkey);
-       path->pathrec.numb_path = 1;
+       path->pathrec.sgid          = priv->local_gid;
+       path->pathrec.pkey          = cpu_to_be16(priv->pkey);
+       path->pathrec.numb_path     = 1;

Did you just wanted to add space/tab here? also some lines are broken at least as my email see this patch, maybe you had some problem?

+       path->pathrec.traffic_class = priv->broadcast->mcmember.traffic_class;

For this to take effect, don't you need to set the IB_SA_PATH_REC_TRAFFIC_CLASS bit in the component mask?

Or.

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to