Sean Hefty wrote:
librdmacm: add valgrind support.
Signed-off-by: Dotan Barak <[EMAIL PROTECTED]>
Signed-off-by: Sean Hefty <[EMAIL PROTECTED]>
---
Changes from the posted patches:
* I combined both patches into a single patch.
* I tried to keep the config file simple and went with the option of
only including memcheck.h if valgrind support was requested.
* The check for memcheck.h is not done if disable_libcheck is true.
* VALGRIND_MAKE_MEM_DEFINED is only defined if memcheck.h is not
included. I would rather fail the build if memcheck.h does not
define this, than print a warning and define it ourselves.
If there's a problem with any of these choices, please let me know.
I have a comment only on your last choice: i don't know the feature
history of valgrind but i believe that
there were versions which had the file memcheck.h without the mentioned
macro.
I would like to leave the code that handles this issue like it was in
the original patch (if it is fine with you).
thanks
Dotan
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
