On Fri, Sep 14, 2007 at 02:31:37PM +0530, Krishna Kumar ([EMAIL PROTECTED]) 
wrote:
> @@ -3566,6 +3579,13 @@ int register_netdevice(struct net_device
>               }
>       }
>  
> +     if (dev->features & NETIF_F_BATCH_SKBS) {
> +             /* Driver supports batching skb */
> +             dev->skb_blist = kmalloc(sizeof *dev->skb_blist, GFP_KERNEL);
> +             if (dev->skb_blist)
> +                     skb_queue_head_init(dev->skb_blist);
> +     }
> +

A nitpick is that you should use sizeof(struct ...) and I think it
requires flag clearing in cae of failed initialization?

>       /*
>        *      nil rebuild_header routine,
>        *      that should be never called and used as just bug trap.

-- 
        Evgeniy Polyakov
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to