Eli Cohen wrote:
Implement support for modifying IPOIB CQ moderation params

This can be used to tune at run time the paramters controlling
the event (interrupt) generation rate and thus reduce the overhead
incurred by hadling interrupts resulting in better throughput.

Index: ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib.h
===================================================================
--- ofa_1_3_dev_kernel.orig/drivers/infiniband/ulp/ipoib/ipoib.h        
2007-09-24 13:07:43.000000000 +0200
+++ ofa_1_3_dev_kernel/drivers/infiniband/ulp/ipoib/ipoib.h     2007-09-24 
13:12:21.000000000 +0200
@@ -270,6 +270,13 @@ struct ipoib_cm_dev_priv {
        struct ib_recv_wr       rx_wr;
 };
+struct ipoib_ethtool_st {
+       u16     rx_coalesce_usecs;
+       u16     tx_coalesce_usecs;
+       u16     rx_max_coalesced_frames;
+       u16     tx_max_coalesced_frames;
+};

As IPoIB uses one CQ per device, why you use the tx_ and rx_ prefixes in the structure name (and later propagated into the documentation, mindset of users etc etc). Its confusing, please change it to be <coalesce_usecs, max_coalesced_frames>

Or.

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to