Eli Cohen wrote:
no (in the tenth time) "...support 64 bit DMA" is not the issue handled by this patch but rather high-memory support.

Look again at the original patch (attached) - it's all about adding
HIGH_DMA support and not high memory support.

talking about looking, include/linux/netdevice.h states:

======================================================================
#define NETIF_F_HIGHDMA         32      /* Can DMA to high memory. *
======================================================================

I am just insisting on correct documentation no-less but no-more. Your patch is all about DMA-ing to highmem and nothing about 64 bit DMA

Or.

Add high dma support to ipoib

This patch assumes all IB devices support 64 bit DMA.

Signed-off-by: Eli Cohen <[EMAIL PROTECTED]>

---

Index: linux-2.6.23-rc1/drivers/infiniband/ulp/ipoib/ipoib_main.c
===================================================================
--- linux-2.6.23-rc1.orig/drivers/infiniband/ulp/ipoib/ipoib_main.c     
2007-08-15 20:50:16.000000000 +0300
+++ linux-2.6.23-rc1/drivers/infiniband/ulp/ipoib/ipoib_main.c  2007-08-15 
20:50:27.000000000 +0300
@@ -1079,6 +1079,8 @@ static struct net_device *ipoib_add_port
SET_NETDEV_DEV(priv->dev, hca->dma_device); + priv->dev->features |= NETIF_F_HIGHDMA;
+
        result = ib_query_pkey(hca, port, 0, &priv->pkey);
        if (result) {
                printk(KERN_WARNING "%s: ib_query_pkey port %d failed (ret = 
%d)\n",

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to