Actually to be complete, this one is: Acked-by: Ralph Campbell <[EMAIL PROTECTED]> Acked-by: Hal Rosenstock <[EMAIL PROTECTED]>
-------- Forwarded Message -------- From: Hal Rosenstock <[EMAIL PROTECTED]> To: Roland Dreier <[EMAIL PROTECTED]> Cc: [email protected], Ralph Campbell <[EMAIL PROTECTED]> Subject: [Fwd: [ofa-general] [PATCH] IB/core - remove redundant NULL pointer check in ib_mad_recv_done_handler()] Date: Tue, 23 Oct 2007 15:04:15 -0700 Hi Roland, This is patch 1. Hope my mailer doesn't munge it. Acked-by: Hal Rosenstock <[EMAIL PROTECTED]> -- Hal -------- Forwarded Message -------- From: Ralph Campbell <[EMAIL PROTECTED]> To: openib <[email protected]> Subject: [ofa-general] [PATCH] IB/core - remove redundant NULL pointer check in ib_mad_recv_done_handler() Date: Wed, 17 Oct 2007 18:06:42 -0700 In ib_mad_recv_done_handler(), the response pointer is checked for NULL after allocating it. It is then checked again in the local process_mad() path but there is no possibility of it changing in between. Signed-off-by: Ralph Campbell <[EMAIL PROTECTED]> diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index 6f42877..f82900d 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -1931,15 +1931,6 @@ local: if (port_priv->device->process_mad) { int ret; - if (!response) { - printk(KERN_ERR PFX "No memory for response MAD\n"); - /* - * Is it better to assume that - * it wouldn't be processed ? - */ - goto out; - } - ret = port_priv->device->process_mad(port_priv->device, 0, port_priv->port_num, wc, &recv->grh, _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
