I'm missing something with this patch set... 

 > Leave create_cq for userspace CQs as before, to avoid breaking ABI.
 > (Handle this in separate libmlx4 patch)

You don't want to break the ABI, which is very good.  But...

 > -    dev->caps.max_cqes           = dev_cap->max_cq_sz - 1;
 > +    dev->caps.max_cqes           = dev_cap->max_cq_sz;

Unless I'm confused, this will lead to userspace seeing a larger limit
for the max number of CQEs.  Which will mean that an old libmlx4 will
fail to create a CQ if the consumer asks for the largest possible CQ, right?

 - R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to