On Fri, 7 Dec 2007, Arlin Davis wrote:
> > 2/2 uDAPL changes. > > - add DAT_API to specify calling conventions (windows=__stdcall, linux= ) > - cleanup CR+LF's > > Signed-off by: Arlin Davis <[EMAIL PROTECTED]> Looks good. A few more minor question: > diff --git a/dapl/common/dapl_csp.c b/dapl/common/dapl_csp.c > index 6c0aaf2..678ca79 100755 > --- a/dapl/common/dapl_csp.c > +++ b/dapl/common/dapl_csp.c > @@ -46,12 +46,12 @@ > * > * uDAPL: User Direct Access Program Library Version 2.0, 6.4.4.2 > * > - * The Common Service Point is transport-independent analog of the Public > - * Service Point. It allows the Consumer to listen on socket-equivalent for > - * requests for connections arriving on a specified IP port instead of > + * The Common Service Point is transport-independent analog of the Public > + * Service Point. It allows the Consumer to listen on socket-equivalent for > + * requests for connections arriving on a specified IP port instead of > * transport-dependent Connection Qualifier. An IA Address follows the > - * platform conventions and provides among others the IP port to listen on. > - * An IP port of the Common Service Point advertisement is supported by > + * platform conventions and provides among others the IP port to listen on. > + * An IP port of the Common Service Point advertisement is supported by > * existing Ethernet infrastructure or DAT Name Service. > * > * Input: What are the change above? I don't see any difference between the text or the white space. > diff --git a/dapl/common/dapl_ep_post_rdma_read_to_rmr.c > b/dapl/common/dapl_ep_post_rdma_read_to_rmr.c > index 929186f..2b1210d 100755 > --- a/dapl/common/dapl_ep_post_rdma_read_to_rmr.c > +++ b/dapl/common/dapl_ep_post_rdma_read_to_rmr.c > @@ -46,7 +46,7 @@ > * > * DAPL Requirements Version xxx, 6.6.24 > * > - * Requests the transfer of all the data specified by the remote_buffer > + * Requests the transfer of all the data specified by the remote_buffer > * over the connection of the ep_handle Endpoint into the local_iov > * specified by the RMR segments. > * ditto > diff --git a/dapl/common/dapl_ep_post_send_invalidate.c > b/dapl/common/dapl_ep_post_send_invalidate.c > index 5ce0808..68a3a51 100755 > --- a/dapl/common/dapl_ep_post_send_invalidate.c > +++ b/dapl/common/dapl_ep_post_send_invalidate.c > @@ -46,7 +46,7 @@ > * > * DAPL Requirements Version xxx, 6.6.21 > * > - * Requests a transfer of all the data from the local_iov over the connection > + * Requests a transfer of all the data from the local_iov over the connection > * of the ep_handle Endpoint to the remote side and invalidates the Remote > * Memory Region context. > * ditto _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
