Roland, On Mon, 2008-01-14 at 13:24 -0800, Roland Dreier wrote: > > >- down_write(&file->port->mutex); > > >+ mutex_unlock(&file->port->file_mutex); > > > > This should be mutex_lock(). > > Yup, thanks... I fixed it in my tree. I guess I never tested > unregistering a MAD agent... > > > The other changes look okay. With your latest patch and the change above, > I was > > not able to reproduce the lockdep warnings. (I've seen the warnings 3 or 4 > > times now, but it's not easy to reproduce.) > > OK, thanks. I think these changes are an improvement anyway, so I > guess I'll queue them up for 2.6.25 and hope things are fixed...
Has there been any OpenSM (and diags) testing with this ? I'd like Sasha to ack this change (including testing multiple instances of opensm) prior to submitting this to 2.6.25. -- Hal > - R. > _______________________________________________ > general mailing list > [email protected] > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general > > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
