Do not use memcpy when copying to the BlueFlame buffer.
memcpy implementations may use move-string-buffer (byte-wise
copy) assembler instructions, which do not guarantee copy order
into the blueflame buffer.
NOTE: This is Roland's version of the fix.
Signed-off-by: Jack Morgenstein <[EMAIL PROTECTED]>
---
Roland,
I notice that you have not yet had a chance to apply this patch (your version,
except that I changed sizeof (long) to sizeof (unsigned long) ).
I'm just posting it "officially".
- Jack
diff --git a/src/qp.c b/src/qp.c
index bced740..4322513 100644
--- a/src/qp.c
+++ b/src/qp.c
@@ -168,6 +168,20 @@ static void set_data_seg(struct mlx4_wqe_data_seg *dseg,
struct ibv_sge *sg)
dseg->byte_count = htonl(sg->length);
}
+/*
+ * Avoid using memcpy() to copy to BlueFlame page, since memcpy()
+ * implementations may use move-string-buffer assembler instructions,
+ * which do not guarantee order of copying.
+ */
+static void mlx4_bf_copy(unsigned long *dst, unsigned long *src, unsigned
bytecnt)
+{
+ while (bytecnt > 0) {
+ *dst++ = *src++;
+ *dst++ = *src++;
+ bytecnt -= 2 * sizeof (unsigned long);
+ }
+}
+
int mlx4_post_send(struct ibv_qp *ibqp, struct ibv_send_wr *wr,
struct ibv_send_wr **bad_wr)
{
@@ -391,7 +405,8 @@ out:
pthread_spin_lock(&ctx->bf_lock);
- memcpy(ctx->bf_page + ctx->bf_offset, ctrl, align(size * 16,
64));
+ mlx4_bf_copy(ctx->bf_page + ctx->bf_offset, (unsigned long *)
ctrl,
+ align(size * 16, 64));
wc_wmb();
ctx->bf_offset ^= ctx->bf_buf_size;
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
