Thanks, applied... > --- a/drivers/infiniband/ulp/ipoib/ipoib.h > +++ b/drivers/infiniband/ulp/ipoib/ipoib.h
> +static inline int ipoib_dma_map_tx(struct ib_device *ca, > + struct ipoib_tx_buf *tx_req) I didn't see why this needed to be in a header-- I just moved it to ipoib_ib.c. Also > + int frags; > + int i; > + > + mapping[0] = ib_dma_map_single(ca, skb->data, skb_headlen(skb), > + DMA_TO_DEVICE); > + if (unlikely(ib_dma_mapping_error(ca, mapping[0]))) > + return -EIO; > + > + frags = skb_shinfo(skb)->nr_frags; Not sure what the advantage of having a local variable that is only used once to hold the value of nr_frags, so I got rid of it. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
