> @@ -505,6 +509,7 @@ struct ib_qp_init_attr {
 >      enum ib_sig_type        sq_sig_type;
 >      enum ib_qp_type         qp_type;
 >      u8                      port_num; /* special QP types only */
 > +    enum qp_create_flags    create_flags;
 >  };

I'm dubious about this.  It seems to me like everything (including the
mlx4 low-level driver changes for LSO) would be simpler to implement
and use if we just extend the qp_type to include IB_QPT_UD_LSO.  For
example it eliminates the need to test if someone tries to create an
LSO QP for a non-UD transport and return an error (although I don't
see that test in your code anyway).

As I recall, the XRC patches want this flags field too.  But does it
work there if we just add another XRC QP type too?

 - R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to