Roland Dreier wrote:
 > @@ -622,7 +624,8 @@ enum ib_wr_opcode {
 > + IB_WR_LSO

 > @@ -630,7 +633,8 @@ enum ib_send_flags {
 > + IB_SEND_UDP_LSO         = (1<<5)

What is this send flag used for?  It doesn't seem to appear anywhere
else in the patch series and it seems redundant given that you've
defined a new opcode for LSO send requests.

I did a quick grep of the OFED 1.3 kernel tree and IB_SEND_UDP_LSO
only seems to appear once, in the line where it is defined.
I think it would be more clear to have LSO as a send flag as does the checksum offload. So some work request will be just sends, other sends with checksum offload and others sends with checksum offload and lso, etc, etc.

Or.

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to