On Wed, 2008-04-09 at 10:01 +0000, Sasha Khapyorsky wrote: > Hi Ira, > > On 16:48 Tue 08 Apr , [EMAIL PROTECTED] wrote: > > As per Hal's comments change the alternate value for [leaf] HOQ to be > > "infinity" when the user specifies a value larger than "infinity". > > Actually I would prefer original version of the patch. The main reason > is that infinite packet life time is really dangerous thing - in case > when a fabric is routed with credit loops (very common case with default > min-hops routing) it leads to total fabric stuck and not just to some > performance degradation. > > So I think it is safer to reject invalid value and to set the default > (log an error, etc.i). As it was done in the original version of the > patch. > > Hal, do you agree?
Safer yes but I think it is less to the intent of the admin who just doesn't understand the max value for this and that's why I proposed this change. My preference is to max it out but it comes down to a judgment call. There's a downside either way. -- Hal > Sasha > _______________________________________________ > general mailing list > [email protected] > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general > > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
