You have
> +static struct mlx4_db_pgdir *mlx4_alloc_db_pgdir(struct device *dma_device)
> +{
> + struct mlx4_db_pgdir *pgdir;
> +
> + pgdir = kzalloc(sizeof *pgdir, GFP_KERNEL);
> + if (!pgdir)
> + return NULL;
> +
> + bitmap_fill(pgdir->order1, MLX4_DB_PER_PAGE / 2);
and so on...
If you're going to move the doorbell stuff from mlx4_ib to mlx4_core,
that's fine, but really move it: you should remove the code from mlx4_ib
and use the stuff in mlx4_core rather than having the same stuff
duplicated in two places. Especially since as this patch stands now,
there are *no* users for the doorbell code in mlx4_core.
- R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
