On Sun, 20 Apr 2008, Roland Dreier wrote: | > | so clearly ipath_init_iba7220_funcs() was intended to be built and used | > | even if CONFIG_PCI_MSI was not defined. From the code it looks like all | > | should work fine if PCI_MSI is not set, so I don't know what you mean | > | about conditional checks. | > | > Actually, it wasn't. It was a late cleanup for another problem, and | > we didn't worry about the other issue, and should have. | | Sorry, I still don't follow. What is the antecedent of "it"? What was | "the other issue"?
The CONFIG_PCI_MSI check where init_iba7220 is called. | I'm not sure I know the right fix for the build breakage. It seems | there are two possibilities: | | - build the iba7220 support unconditionally (the patch I posted). Yep; I already said I was OK with that. It's simplest, let's go with it. | And given that at least some device support works even if neither | PCI_MSI nor HT_IRQ is defined, then it makes sense to me to remove that | Kconfig dependency. Go ahead. Dave Olson [EMAIL PROTECTED] _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
