> Clean up the SFP+ patch.
Why send a patch and then immediately a cleanup? Why not just clean the
original patch?
> - if ((nesadapter->OneG_Mode) && (nesadapter->phy_type[mac_index] !=
> NES_PHY_TYPE_PUMA_1G)) {
> + if ((nesadapter->OneG_Mode) && (nesadapter->phy_type[ mac_index ] !=
> NES_PHY_TYPE_PUMA_1G)) {
This type of change isn't a cleanup... kernel style prefers
array[index]
to
array[ index ]
and it seems most of this patch is making the change to the less-good way?
- R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
