> +module_param_named(debug_level, iser_debug_level, int, > S_IRUGO|S_IWUSR|S_IWGRP); > +MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0 > (default:disabled)");
In addition to being line-wrapped this looks really funny... why add S_IWGRP? The ownership of parameter files is root:root so what do you get from changing from the current 0644 permissions? I applied the patch without this change, if there is a reason for this, please send the permission change separately. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
