Sorry for the resend. Original mail bounced from netdev. On Thu, May 1, 2008 at 9:48 PM <[EMAIL PROTECTED]> wrote: > Stephen, > > > Stephen Hemminger [mailto:[EMAIL PROTECTED] wrote: > > > Ramachandra K <[EMAIL PROTECTED]> wrote: > > >> +#define is_power_of2(value) (((value) & ((value - 1))) == 0) > >> +#define ALIGN_DOWN(x, a) ((x)&(~((a)-1))) > > > In kernel.h already > > Will fix this. Thanks. > > > >> +extern u32 vnic_debug; > > > Use msg level macros instead? > > I am sorry, I did not understand this comment. > > > > + > > +#define SYS_INFO(fmt, arg...) \ > > + PRINT_CONDITIONAL(KERN_INFO, \ > > + "SYS", \ > > + (vnic_debug & DEBUG_SYS_INFO), \ > > + fmt, ##arg) > > + > > +#endif /* VNIC_UTIL_H_INCLUDED */ > > > > Many of these are already in standard macros pr_info, pr_err etc. > > These macros are for providing a debug log level functionality through > the vnic_debug module parameter. > > Regards, > Ram _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
