> The purpose of this patch is to make the events that are related to SM change > (namely CLIENT_REREGISTER event and SM_CHANGE event) less disruptive. > When SM related events are handled, it is not necessary to flush unicast > info from device but only multicast info. This patch divides the events that > are > handled by IPoIB to three categories; 0, 1 and 2 (when 2 does more than 1 > and 1 > does more than 0).
I see two issues with this patch: - Is is architecturally guaranteed by the IB spec that flushing unicast info is not required on an SM change or client reregister event? - The implementation looks to make maintainability somewhat harder, since it's not very clear what level 0, 1, and 2 events really mean. I suggest using some symbolic names (maybe bitmasks that are |ed together?) to make it explicit what is being flushed. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
