On 09:20 Mon 09 Jun , Hal Rosenstock wrote:
> OpenSM/osm_sa_path_record.c: Add some information to some error log
> messages
> Also, some commentary changes to this and osm_sa_multipath_record.c
>
> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]>
Applied. Thanks. And few comments are below.
> @@ -1220,7 +1220,7 @@ __osm_pr_rcv_get_end_points(IN osm_sa_t * sa,
> Return an error response to the client.
> */
> OSM_LOG(sa->p_log, OSM_LOG_VERBOSE,
> - "No source port with LID = 0x%X\n",
> + "No source port with LID 0x%X\n",
AFAIR we decided to use decimal representation for unicast LIDs. I know
that this patch has another goal, just reminder... (for me :))
> @@ -1516,7 +1518,7 @@ __osm_pr_get_mgrp(IN osm_sa_t * sa,
> if ((*pp_mgrp)->mlid != p_pr->dlid) {
> /* Note: perhaps this might be better indicated
> as an invalid request */
> OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1F10: "
> - "MC group MLID does not match
> PathRecord destination LID\n");
> + "MC group MLID 0x%x does not match
> PathRecord destination LID 0x%x\n", (*pp_mgrp)->mlid, p_pr->dlid);
> *pp_mgrp = NULL;
> goto Exit;
> }
> @@ -1524,7 +1526,7 @@ __osm_pr_get_mgrp(IN osm_sa_t * sa,
> *pp_mgrp = __get_mgrp_by_mlid(sa, p_pr->dlid);
> if (*pp_mgrp == NULL)
> OSM_LOG(sa->p_log, OSM_LOG_ERROR, "ERR 1F11: "
> - "No MC group found for PathRecord
> destination LID\n");
> + "No MC group found for PathRecord
> destination LID 0x%x\n", p_pr->dlid);
Break long lines, please.
Sasha
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
