> The parameters that we wanted to be log2 values are those that must be > a power of 2. > These new parameters do not have this limitation, and thus no need for > log2 requirement.
How the heck is the end-user supposed to know or care which parameters are which? Plus: > +module_param_named(num_mac, num_mac, int, 0444); > +MODULE_PARM_DESC(num_mac, "Maximum number of MACs per ETH port " > + "(1-127, default 1)"); > + dev->caps.log_num_macs = ilog2(roundup_pow_of_two(num_mac + 1)); and so on... so it sure looks like a power of two to me. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
