> I did ran the script on the patch and besides one WARNING for
> a line that exceeds 80 columns which I believe is allowed sometimes.
Too-long lines are OK with me, but I get the following with the patch I
was replying to:
WARNING: line over 80 characters
#181: FILE: drivers/infiniband/ulp/ipoib/ipoib_main.c:266:
+ be16_to_cpu(path->pathrec.dlid),
IPOIB_GID_ARG(path->pathrec.dgid));
ERROR: space required after that ',' (ctx:VxV)
#275: FILE: drivers/infiniband/ulp/ipoib/ipoib_main.c:665:
+ ipoib_dbg(priv,"path does not exist\n");
^
ERROR: space required after that ',' (ctx:VxV)
#278: FILE: drivers/infiniband/ulp/ipoib/ipoib_main.c:668:
+ ipoib_dbg(priv,"path exists but invalid\n");
^
ERROR: space required after that ',' (ctx:VxV)
#310: FILE: drivers/infiniband/ulp/ipoib/ipoib_verbs.c:292:
+ ipoib_dbg(priv, "Event %d on device %s port %d\n",record->event,
^
ERROR: space prohibited after that open parenthesis '('
#312: FILE: drivers/infiniband/ulp/ipoib/ipoib_verbs.c:294:
+ if ( record->event == IB_EVENT_SM_CHANGE ||
total: 4 errors, 1 warnings, 258 lines checked
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
