On Wed, 2008-06-25 at 14:47 +0300, Or Gerlitz wrote:
> Jan-Bernd Themann wrote:
> > no, what I meant is that it is only not needed at that particular
> > place as the packet is not handled by LRO. Without this line the
> > driver can set an individual value for each SKB that is not
> > aggregated if wished. For example when the packet is not a valid IP
> > packet. However, removing all ip_summed fields impacts the fragment
> > lro mode. There we have to set some value for not aggregated packets.
> > The SKBs are generated within the LRO engine. If desired (and if there
> > is HW that wants to use that) we can pass that value for each provided
> > fragment. This would add one additional paramter to the already 8
> > parameters of __lro_proc_segment. That is of course possible.
> OK, understood, both points.
>
> Eli, lets add to this patch a comment in inet_lro.h saying that the
> value of lro_mgr->ip_summed is ignored by the core lro code for drivers
> that use the non fragmented mode.
We already have this comment:
struct net_lro_mgr {
...
u32 ip_summed; /* Set in non generated SKBs in page mode */
I think we should use have it something like that:
...
/*
* Set for generated SKBs in that are not added to
* the frag list in fragmented mode
*/
u32 ip_summed;
What do you think?
> Also for the ipoib patch, lets not set
> this value.
Agree.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
