Roland Dreier wrote:
> +extern int ipoib_use_lro; > +extern int ipoib_lro_max_aggr;
Roland,
I the past, few times you have commented that as far as its possible to go without mod params, this should be the practice... for example here sysfs entries set by various hotplug mechanisms, or telling the user to upgrade their ethtool package, etc could serve to eliminate the need in mod params.
During the review I asked why the default value for max_aggr is 64 and it was ignored, also what we want the default value for use_lro to be? I recall there was once a comment from Dave Miller saying why it would be wise to have it off by default, I will look for that.
Or. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
