On Thursday 03 July 2008 23:34:12 Jon Mason wrote: > This patch adds support for running RDS over iWARP adapters. It > requires the fast_reg_mr patches and Olaf's RDS patches (for the flow > control enablement) to apply cleanly and build. It also includes the > patch I sent out earlier to have different connection ports for IB, TCP, > and IWARP. > > It is a "work in progress", but I would like for people to take a look
Thanks for posting the code at this stage. I will have a closer look tomorrow and see how much of the code it duplicates from ib*.c actually could be shared. As Or already noted, it would be preferable to have IB and iWARP share as much as possible. I understand there probably needs to be a different transport class for iWARP, but I would like iWARP to be some kind of "we do everything like IB except these two little bits" transport. > The bulk of the code is a copy of the RDS IB with the changes necessary > to get iWARP working. Thus there may be stale comments and redundant > code. I will audit the code to remove the stale comments, and remove > duplicated and unmodified code (but feel free to point out any that you > see). I'll go over it tomorrow and see how much can be accomodated in the existing transport interface, and what needs additional function pointers. > Olaf, if you would like to pull this into your personal tree, I can > provide you with delta patches until it is accepted into the OFED 1.4 > tree (assuming that you have no major problem with the code below). Thanks, let's see how far we get with breaking this down into pieces. Okay? Regards, Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] | / | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
