> This patch seems broken:
It is broken.
>
> > @@ -842,7 +845,12 @@ static void
> nes_netdev_set_multicast_list(struct net_device *netdev) >
> > + spin_lock_irqsave(&nesadapter->resource_lock, flags);
>
> nes_netdev_set_multicast_list() takes resource lock
> unconditionally here, but...
>
> > if (!mc_all_on) {
>
> ...
>
> > +
> spin_unlock_irqrestore(&nesadapter->resource_lock, flags);
> > }
> > }
spin_unlock_irqrestore should be outside of the if(...).
+ if (!mc_all_on) {
+ ...
+ nes_write_indexed(nesdev,
NES_IDX_NIC_UNICAST_ALL,
+
nic_active);
+ }
}
+ spin_unlock_irqrestore(&nesadapter->resource_lock, flags);
}
If you can fix it again that would be great but let me know if you want
a v2 patch.
Chien
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
