Hey Sasha,

This is a code cleanup patch renaming "all" to "all_ports" for
consistency to other code in perfquery.

Al

-- 
Albert Chu
[EMAIL PROTECTED]
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory
>From 2ea814a30d3b5e1df64e122382a1952b875f03fd Mon Sep 17 00:00:00 2001
From: Albert Chu <[EMAIL PROTECTED]>
Date: Thu, 9 Oct 2008 16:39:13 -0700
Subject: [PATCH] rename all to all_ports for clarity to optionname


Signed-off-by: Albert Chu <[EMAIL PROTECTED]>
---
 infiniband-diags/src/perfquery.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/infiniband-diags/src/perfquery.c b/infiniband-diags/src/perfquery.c
index 0d1b061..69a00d4 100644
--- a/infiniband-diags/src/perfquery.c
+++ b/infiniband-diags/src/perfquery.c
@@ -126,7 +126,7 @@ main(int argc, char **argv)
 	extern int ibdebug;
 	int dest_type = IB_DEST_LID;
 	int timeout = 0;	/* use default */
-	int mask = 0xffff, all = 0;
+	int mask = 0xffff, all_ports = 0;
 	int reset = 0, reset_only = 0;
 	int port = 0;
 	int udebug = 0;
@@ -178,7 +178,7 @@ main(int argc, char **argv)
 			extended = 1;
 			break;
 		case 'a':
-			all++;
+			all_ports++;
 			port = ALL_PORTS;
 			break;
 		case 'l':
@@ -241,13 +241,13 @@ main(int argc, char **argv)
 	memcpy(&cap_mask, pc+2, sizeof(cap_mask));	/* CapabilityMask */
 	cap_mask = ntohs(cap_mask);
 	if (!(cap_mask & 0x100)) { /* bit 8 is AllPortSelect */
-		if (!all && port == ALL_PORTS)
+		if (!all_ports && port == ALL_PORTS)
 			IBERROR("AllPortSelect not supported");
-		if (all)
+		if (all_ports)
 			all_ports_loop = 1;
 	}
 
-	if (all_ports_loop || (loop_ports && (all || port == ALL_PORTS))) {
+	if (all_ports_loop || (loop_ports && (all_ports || port == ALL_PORTS))) {
 		if (smp_query(data, &portid, IB_ATTR_NODE_INFO, 0, 0) < 0)
 			IBERROR("smp query nodeinfo failed");
 		node_type = mad_get_field(data, 0, IB_NODE_TYPE_F);
@@ -269,7 +269,7 @@ main(int argc, char **argv)
 	if (reset_only)
 		goto do_reset;
 
-	if (all_ports_loop || (loop_ports && (all || port == ALL_PORTS))) {
+	if (all_ports_loop || (loop_ports && (all_ports || port == ALL_PORTS))) {
 		for (i = start_port; i <= num_ports; i++)
 			dump_perfcounters(extended, timeout, cap_mask, &portid, i);
 	}
@@ -281,7 +281,7 @@ main(int argc, char **argv)
 
 do_reset:
 
-	if (all_ports_loop || (loop_ports && (all || port == ALL_PORTS))) {
+	if (all_ports_loop || (loop_ports && (all_ports || port == ALL_PORTS))) {
 		for (i = start_port; i <= num_ports; i++)
 			reset_counters(extended, timeout, mask, &portid, i);
 	}
-- 
1.5.4.5

_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to