Looks good, applied. However, I think it's a little yucky to call ethtool ops without rtnl, although it is of course perfectly safe in this case. It might be nicer to introduce a new cxgb3 <-> iw_cxgb3 interface that returns the firmware version, which can also be used to implement the get_drvinfo ethtool op as well. That would let you avoid fw_vers_string_to_u64() as well -- it is a little silly at the moment how cxgb3 converts to a string and then iw_cxgb3 parses that string.
But that's all much lower priority than just fixing a deadlock. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
