>Yes, it's a tricky balance.  You don't want to combine multiple ideas in
>one patch, because such patches are hard to review and hard to debug
>later.  But splitting one ideas into multiple patches also causes
>similar problems (and you have to get the pieces in the right order
>too).  And of course the whole question of what constitues an "idea" is
>rather subjective.  So we just do the best we can.

The patch set taken collectively looks good to me.  I think it makes sense to
view the series as 2 patches, one for ib_addr (patches 4-6), and one for rdma_cm
(patches 1-3).  The ib_addr patch should come first.

- Sean

_______________________________________________
general mailing list
general@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Reply via email to