On Tue, Jan 27, 2009 at 5:18 AM, Evgeniy Polyakov <[email protected]> wrote:
> On Mon, Jan 26, 2009 at 06:17:41PM -0800, Andy Grover
> ([email protected]) wrote:
>> +static LIST_HEAD(transports);
>> +static DECLARE_RWSEM(trans_sem);
>> +
>
> RDS_ prefix?
Even needed for statics?
>> +int rds_trans_register(struct rds_transport *trans)
>> +{
>> + BUG_ON(strlen(trans->t_name) + 1 >
>> + sizeof(((struct rds_info_connection *)0)->transport));
>> +
>
> Wow. Why not declare 15 as some constant and put it into rds_transport
> structure definition?
Makes sense.
>> + if (IN_LOOPBACK(ntohl(addr)))
>> + return &rds_loop_transport;
>> +
>
> Tabs have run away.
Will fix. Thanks.
Regards -- Andy
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
